Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Organisation Lookup #2756

Merged
merged 28 commits into from
Dec 4, 2024
Merged

Feature/Organisation Lookup #2756

merged 28 commits into from
Dec 4, 2024

Conversation

HauklandJ
Copy link
Contributor

@HauklandJ HauklandJ commented Nov 26, 2024

Description

Related Issue(s)

  • closes #{issue number}

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@HauklandJ HauklandJ added kind/feature-request New feature or request kind/product-feature Pull requests containing new features and removed kind/feature-request New feature or request labels Nov 26, 2024
@HauklandJ HauklandJ changed the title add organisation lookup component Feature/Organisation Lookup Nov 26, 2024
@HauklandJ HauklandJ linked an issue Nov 27, 2024 that may be closed by this pull request
@HauklandJ HauklandJ marked this pull request as ready for review November 29, 2024 13:01
@HauklandJ HauklandJ requested a review from cammiida December 4, 2024 10:50
Copy link
Contributor

@cammiida cammiida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Copy link

sonarcloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
29.5% Coverage on New Code (required ≥ 45%)
9.8% Duplication on New Code (required ≤ 3%)
1.39% Condition Coverage on New Code (required ≥ 45%)

See analysis details on SonarQube Cloud

@HauklandJ HauklandJ merged commit 5995fbf into main Dec 4, 2024
13 of 14 checks passed
@HauklandJ HauklandJ deleted the feature/organisation-lookup branch December 4, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organisation lookup component
2 participants